Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update with-reasonml to with-rescript example #24898

Closed
wants to merge 3 commits into from
Closed

Update with-reasonml to with-rescript example #24898

wants to merge 3 commits into from

Conversation

ryyppy
Copy link

@ryyppy ryyppy commented May 7, 2021 •
edited
Loading

Hey!

ReasonML & BuckleScript have officially rebranded to ReScript, so I'd like to deprecate with-reasonml in favour of a with-rescript example.

I updated all the dependencies and converted the original example to ReScript / React.

(will follow up with another PR for with-reasonml-todo later on)

Bug

  • Related issues linked using fixes #number
  • Integration tests added

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

  • Make sure the linting passes

@ijjk ijjk added the examples Issue was opened via the examples template. label May 7, 2021
This was referenced May 7, 2021
Closed
Open
@balazsorban44
Copy link
Member

Hi @ryyppy, there seem to be merge conflicts here, do you have the intention to bring this PR up-to-date? If not, let's close it for now. Thanks either way! 🙏 💚

@ijjk ijjk force-pushed the canary branch 3 times, most recently from df8579c to 47e5ebe Compare October 25, 2022 16:15
@ijjk ijjk force-pushed the canary branch 2 times, most recently from e078ebe to 6b863fe Compare December 2, 2022 05:49
@leerob
Copy link
Member

leerob commented Jan 4, 2023

Closing as stale – if you would like to continue this, please open a new PR and we can take a look. Thank you so much! 🙏

@leerob leerob closed this Jan 4, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@divmain divmain Awaiting requested review from divmain

@ijjk ijjk Awaiting requested review from ijjk

@leerob leerob Awaiting requested review from leerob

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

@steven-tey steven-tey Awaiting requested review from steven-tey

@balazsorban44 balazsorban44 Awaiting requested review from balazsorban44

Assignees
No one assigned
Labels
examples Issue was opened via the examples template.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ryyppy @balazsorban44 @leerob @ijjk